[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75Ve2sLrNZGjD=1LHbyzQEuB2GMhXJxmBgQo1Y4eCHzPk+A@mail.gmail.com>
Date: Thu, 5 Nov 2015 21:32:57 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: David Miller <davem@...emloft.net>
Cc: Sowmini Varadhan <sowmini.varadhan@...cle.com>,
intel-wired-lan@...ts.osuosl.org, netdev <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
"Nelson, Shannon" <shannon.nelson@...el.com>,
"Wyborny, Carolyn" <carolyn.wyborny@...el.com>,
"Skidmore, Donald C" <donald.c.skidmore@...el.com>,
"Vick, Matthew" <matthew.vick@...el.com>,
"Ronciak, John" <john.ronciak@...el.com>,
"Williams, Mitch A" <mitch.a.williams@...el.com>
Subject: Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM
On Thu, Nov 5, 2015 at 8:31 PM, David Miller <davem@...emloft.net> wrote:
> From: Andy Shevchenko <andy.shevchenko@...il.com>
> Date: Thu, 5 Nov 2015 20:13:21 +0200
>
>> What about
>>
>> if (!addr)
>> return -ENODATA;
>
> I totally disagree. of_get_phy_mode() and other similar attribute
> probing mechanisms use -ENODEV.
Okay, then just
if (!addr)
return -ENODEV;
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists