linux-kernel - Re: [PATCH 00/28] tracing: 'hist' triggers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1446761582.26677.77.camel@tzanussi-mobl.amr.corp.intel.com>
Date:	Thu, 05 Nov 2015 16:13:02 -0600
From:	Tom Zanussi <tom.zanussi@...ux.intel.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	rostedt@...dmis.org, daniel.wagner@...-carit.de,
	masami.hiramatsu.pt@...achi.com, josh@...htriplett.org,
	andi@...stfloor.org, mathieu.desnoyers@...icios.com,
	peterz@...radead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/28] tracing: 'hist' triggers

Hi Namhyung,

On Thu, 2015-11-05 at 23:43 +0900, Namhyung Kim wrote:
> Hi Tom,
> 
> I implemented 'log2' modifier on top of your v11 patchset.  Could you
> please take a look at this?
> 

Very nice, thanks for doing this.

I just noticed one small problem in that the modifier doesn't get
printed in the output.  The below patch fixes that.

I can just merge that change into your patch and add it to my series,
otherwise please let me know what you'd like me to do.. 

Tom

Signed-off-by: Tom Zanussi <tom.zanussi@...ux.intel.com>
---
 kernel/trace/trace_events_hist.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/trace/trace_events_hist.c
b/kernel/trace/trace_events_hist.c
index 20a17fd..7621748 100644
--- a/kernel/trace/trace_events_hist.c
+++ b/kernel/trace/trace_events_hist.c
@@ -1092,6 +1092,8 @@ static const char *get_hist_field_flags(struct
hist_field *hist_field)
                flags_str = "execname";
        else if (hist_field->flags & HIST_FIELD_SYSCALL)
                flags_str = "syscall";
+       else if (hist_field->flags & HIST_FIELD_LOG2)
+               flags_str = "log2";
 
        return flags_str;
 }



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/