linux-kernel - Re: [RFC PATCH 3/7] spi: tegra: remove redundant "depends on RESET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151106102237.GX18409@sirena.org.uk>
Date:	Fri, 6 Nov 2015 10:22:37 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	linux-spi@...r.kernel.org
Subject: Re: [RFC PATCH 3/7] spi: tegra: remove redundant "depends on
 RESET_CONTROLLER"

On Fri, Nov 06, 2015 at 03:02:57PM +0900, Masahiro Yamada wrote:
> 2015-11-05 20:50 GMT+09:00 Mark Brown <broonie@...nel.org>:
> > On Thu, Nov 05, 2015 at 08:15:24PM +0900, Masahiro Yamada wrote:
> >> ARCH_TEGRA selects RESET_CONTROLLER.
> >> The dependency "depends on RESET_CONTROLLER" is already met.

> >>       tristate "NVIDIA Tegra114 SPI Controller"
> >>       depends on (ARCH_TEGRA && TEGRA20_APB_DMA) || COMPILE_TEST
> >> -     depends on RESET_CONTROLLER && HAS_DMA
> >> +     depends on HAS_DMA

> > Again, this driver doesn't depend on ARCH_TEGRA.

> How come?

> Sorry, I have not been tracking this sub-system,
> so I do not get the "Again".

It's the same issue as your previous patch - there's an || COMPILE_TEST
in there.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)