lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Nov 2015 12:40:09 +0900 From: Masahiro Yamada <yamada.masahiro@...ionext.com> To: Linus Walleij <linus.walleij@...aro.org> Cc: Vishnu Patekar <vishnupatekar0510@...il.com>, "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Hans de Goede <hdegoede@...hat.com>, Chen-Yu Tsai <wens@...e.org>, Philipp Zabel <p.zabel@...gutronix.de>, Maxime Ripard <maxime.ripard@...e-electrons.com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: Re: [RFC PATCH 4/7] pinctrl: sunxi: remove redundant "depends on RESET_CONTROLLER" Hi Linus 2015-11-05 22:40 GMT+09:00 Linus Walleij <linus.walleij@...aro.org>: > On Thu, Nov 5, 2015 at 12:15 PM, Masahiro Yamada > <yamada.masahiro@...ionext.com> wrote: > >> ARCH_SUNXI selects RESET_CONTROLLER. >> The dependency "depends on RESET_CONTROLLER" is already met. >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com> > > NACK, this pin controller needs that as dependency, I don't worry > that it's overspecified. > > They both do this: > #include <linux/reset.h> > > And the object should specify its dependencies, not rely on them > being implicitly available. > > The dep is there for human readers too, not just machines. And to > them, this is helpful information. How strict we should follow this rule? Many drivers depend on OF, but do they all have "depends on OF"? -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists