lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 8 Nov 2015 13:46:47 +0700 From: Ivan Safonov <insafonov@...il.com> To: devel@...verdev.osuosl.org Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Vaishali Thakkar <vthakkar1994@...il.com>, Jakub Sitnicki <jsitnicki@...il.com>, Anish Bhatt <anish@...ech.edu>, Joe Perches <joe@...ches.com>, Ivan Safonov <insafonov@...il.com>, Nicholas Mc Guire <der.herr@...r.at>, Alexey Khoroshilov <khoroshilov@...ras.ru>, Rémy Oudompheng <remyoudompheng@...il.com>, Sudip Mukherjee <sudipm.mukherjee@...il.com>, Shraddha Barke <shraddha.6596@...il.com>, linux-kernel@...r.kernel.org Subject: [PATCH 08/12] staging: rtl8188eu: if (a) ; else {...} replaced by if (!a) {...} It is looks bit better. Signed-off-by: Ivan Safonov <insafonov@...il.com> --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c index 7c79774..62f83ab 100644 --- a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c @@ -447,9 +447,7 @@ static int wpa_set_encryption(struct net_device *dev, struct ieee_param *param, if (check_fwstate(pmlmepriv, WIFI_STATION_STATE | WIFI_MP_STATE)) { /* sta mode */ psta = rtw_get_stainfo(pstapriv, get_bssid(pmlmepriv)); - if (psta == NULL) { - ; - } else { + if (psta) { if (strcmp(param->u.crypt.alg, "none") != 0) psta->ieee8021x_blocked = false; @@ -482,9 +480,7 @@ static int wpa_set_encryption(struct net_device *dev, struct ieee_param *param, } } pbcmc_sta = rtw_get_bcmc_stainfo(padapter); - if (pbcmc_sta == NULL) { - ; - } else { + if (pbcmc_sta) { /* Jeff: don't disable ieee8021x_blocked while clearing key */ if (strcmp(param->u.crypt.alg, "none") != 0) pbcmc_sta->ieee8021x_blocked = false; -- 2.4.10 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists