linux-kernel - [PATCH 10/12] staging: rtl8188eu: reg_macid variable removed in hw_var_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151108065145.GA1183@alpha.sfu-kras.ru>
Date:	Sun, 8 Nov 2015 13:51:45 +0700
From:	Ivan Safonov <insafonov@...il.com>
To:	devel@...verdev.osuosl.org
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Vaishali Thakkar <vthakkar1994@...il.com>,
	Jakub Sitnicki <jsitnicki@...il.com>,
	Anish Bhatt <anish@...ech.edu>, Joe Perches <joe@...ches.com>,
	Ivan Safonov <insafonov@...il.com>,
	Nicholas Mc Guire <der.herr@...r.at>,
	Alexey Khoroshilov <khoroshilov@...ras.ru>,
	Rémy Oudompheng <remyoudompheng@...il.com>,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Shraddha Barke <shraddha.6596@...il.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH 10/12] staging: rtl8188eu: reg_macid variable removed in
 hw_var_set_macaddr

The reg_macid variable used only once. Also idx renamed to i and Adapter to adapter.

Signed-off-by: Ivan Safonov <insafonov@...il.com>
---
 drivers/staging/rtl8188eu/hal/usb_halinit.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 5789e1e..e1d6632 100644
--- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
+++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
@@ -1253,15 +1253,12 @@ static void hw_var_set_opmode(struct adapter *Adapter, u8 variable, u8 *val)
 	}
 }
 
-static void hw_var_set_macaddr(struct adapter *Adapter, u8 variable, u8 *val)
+static void hw_var_set_macaddr(struct adapter *adapter, u8 variable, u8 *val)
 {
-	u8 idx = 0;
-	u32 reg_macid;
-
-	reg_macid = REG_MACID;
+	int i;
 
-	for (idx = 0; idx < 6; idx++)
-		usb_write8(Adapter, (reg_macid+idx), val[idx]);
+	for (i = 0; i < 6; i++)
+		usb_write8(adapter, REG_MACID + i, val[i]);
 }
 
 static void hw_var_set_bssid(struct adapter *Adapter, u8 variable, u8 *val)
-- 
2.4.10

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/