linux-kernel - Re: [BUG, PATCH 03/10] sysfs: added __compat_only_sysfs_link_entry_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151108074615.GA28014@intel.com>
Date:	Sun, 8 Nov 2015 09:46:15 +0200
From:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:	Jeremiah Mahler <jmmahler@...il.com>,
	tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	peterhuewe@....de, gregkh@...uxfoundation.org,
	jgunthorpe@...idianresearch.com, dhowells@...hat.com,
	artem.bityutskiy@...ux.intel.com, Tejun Heo <tj@...nel.org>,
	NeilBrown <neilb@...e.de>, Guenter Roeck <linux@...ck-us.net>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [BUG, PATCH 03/10] sysfs: added
 __compat_only_sysfs_link_entry_to_kobj()

On Sat, Nov 07, 2015 at 07:04:04PM -0800, Jeremiah Mahler wrote:
> Jarkko,
> 
> On Sun, Nov 08, 2015 at 02:49:06AM +0200, Jarkko Sakkinen wrote:
> > On Sat, Nov 07, 2015 at 03:11:47PM -0800, Jeremiah Mahler wrote:
> > > Jarkko,
> > > 
> [...]
> > > 
> > > It sounds like you have the problem figured out and have a good fix.
> > > If I can do anything else to help let me know :-)
> > 
> > Turns out that after all the second issue that I described was also
> > because of this patch.
> > 
> > Clean up was not done properly when that function. I revised my fix.
> > 
> > If you want to help, check that the revised patch works I'll add
> > Tested-by to the patch. Thank you!
> > 
> > > -- 
> > > - Jeremiah Mahler
> > 
> > /Jarkko
> 
> I tested the patch (link below) and it works with one small caveat.
> The patch would not apply because line 231 uses list_add_tail_rcu
> instead of list_add_rcu.  I am working from commit 9b774d5cf2d where
> the problem started.  Your repo likely has other changes involved.
> 
> https://github.com/jsakkine/linux-tpmdd/commit/73ea7e0b8045f9610c3274bcefaf89b7a05ee781

Yes, that branch also fix that changes one list_add_rcu() to
list_add_tail_rcu(). I'll add Tested-by to the commit message. Thanks
again for the good work.

> -- 
> - Jeremiah Mahler

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/