linux-kernel - Re: [PATCH 03/10] sysfs: added __compat_only_sysfs_link_entry_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151109223216.GA1305@obsidianresearch.com>
Date:	Mon, 9 Nov 2015 15:32:16 -0700
From:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:	Jeremiah Mahler <jmmahler@...il.com>,
	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
	tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	peterhuewe@....de, gregkh@...uxfoundation.org, dhowells@...hat.com,
	artem.bityutskiy@...ux.intel.com, Tejun Heo <tj@...nel.org>,
	NeilBrown <neilb@...e.de>, Guenter Roeck <linux@...ck-us.net>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [PATCH 03/10] sysfs: added
 __compat_only_sysfs_link_entry_to_kobj()

On Fri, Nov 06, 2015 at 04:23:56PM -0800, Jeremiah Mahler wrote:
> On Fri, Oct 16, 2015 at 09:40:22PM +0300, Jarkko Sakkinen wrote:
> > Added a new function __compat_only_sysfs_link_group_to_kobj() that adds
> > a symlink from attribute or group to a kobject. This needed for
> > maintaining backwards compatibility with PPI attributes in the TPM
> > driver.

> One problem with this patch is that it adds a bunch of code but none of
> it is used.  So if there is a bug, git bisect will point to a later
> patch instead of this one.

It is fairly standard practice to split cross-subsystem patches like
this, it aids review. git bisect is not a perfect tool.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/