linux-kernel - Re: [PATCH] crypto: sun4i-ss: add missing statesize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20151109073745.GA3106@gondor.apana.org.au>
Date:	Mon, 9 Nov 2015 15:38:10 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	LABBE Corentin <clabbe.montjoie@...il.com>
Cc:	davem@...emloft.net, maxime.ripard@...e-electrons.com,
	wens@...e.org, linux-crypto@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: sun4i-ss: add missing statesize

On Mon, Nov 09, 2015 at 08:27:06AM +0100, LABBE Corentin wrote:
> sun4i-ss implementaton of md5/sha1 is via ahash algorithms.
> A recent change make impossible to load them without giving statesize.
> This patch specifiy statesize for sha1 and md5.
> 
> Fixes: 8996eafdcbad ("crypto: ahash - ensure statesize is non-zero")

Nack.  As I said this commit is absolutely correct and if you really
have to slap on a fixes header then make it the original changeset
that added the driver.  It's the driver that's broken, not the API.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/