linux-kernel - [PATCH] drm/nouveau/abi16: add missing mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1447060586-23431-1-git-send-email-saurabh.truth@gmail.com>
Date:	Mon,  9 Nov 2015 14:46:26 +0530
From:	Saurabh Sengar <saurabh.truth@...il.com>
To:	airlied@...ux.ie, bskeggs@...hat.com,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Cc:	Saurabh Sengar <saurabh.truth@...il.com>
Subject: [PATCH] drm/nouveau/abi16: add missing mutex_unlock()

adding missing mutex_unlock()

Signed-off-by: Saurabh Sengar <saurabh.truth@...il.com>
---
 drivers/gpu/drm/nouveau/nouveau_abi16.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_abi16.c b/drivers/gpu/drm/nouveau/nouveau_abi16.c
index d336c22..280bd8e 100644
--- a/drivers/gpu/drm/nouveau/nouveau_abi16.c
+++ b/drivers/gpu/drm/nouveau/nouveau_abi16.c
@@ -54,11 +54,11 @@ nouveau_abi16_get(struct drm_file *file_priv, struct drm_device *dev)
 			if (nvif_device_init(&cli->base.object,
 					     NOUVEAU_ABI16_DEVICE, NV_DEVICE,
 					     &args, sizeof(args),
-					     &abi16->device) == 0)
-				return cli->abi16;
+					     &abi16->device)) {
 
-			kfree(cli->abi16);
-			cli->abi16 = NULL;
+				kfree(cli->abi16);
+				cli->abi16 = NULL;
+			}
 		}
 
 		mutex_unlock(&cli->mutex);
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/