linux-kernel - [PATCH] perf tools: Correct typing errors about '-' or '

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon,  9 Nov 2015 19:54:35 +0900
From:	Taeung Song <treeze.taeung@...il.com>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	Taeung Song <treeze.taeung@...il.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Jiri Olsa <jolsa@...hat.com>
Subject: [PATCH] perf tools: Correct typing errors about '-' or '_' in config variable.

To improve perf config usability, we should probably also recognize
underscores in perf config entries, i.e. the following variants
should both work: as suggested by Ingo Molnar

        print_percent = 1
        print-percent = 1

So, add functionality for it.
'annotate' section has variables that contain '_' underscores like:

        hide_src_code
        use_offset
        jump_arrows
        show_nr_jumps

However other sections has variables that contain a '-' dash
or neither it or underscore i.e.

        ui.show-headers
        call-graph.print-limit
        tui.report

So, convert the characters if typing errors about underscores
or a dash when parsing the config file.

Cc: Namhyung Kim <namhyung@...nel.org>
Cc: Jiri Olsa <jolsa@...hat.com>
Signed-off-by: Taeung Song <treeze.taeung@...il.com>
---
 tools/perf/util/config.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c
index 2e452ac..69db606 100644
--- a/tools/perf/util/config.c
+++ b/tools/perf/util/config.c
@@ -129,7 +129,10 @@ static int get_value(config_fn_t fn, void *data, char *name, unsigned int len)
 {
 	int c;
 	char *value;
+	bool has_underscore = false;
 
+	if (prefixcmp(name, "annotate.") == 0)
+		has_underscore = true;
 	/* Get the full name */
 	for (;;) {
 		c = get_next_char();
@@ -137,6 +140,11 @@ static int get_value(config_fn_t fn, void *data, char *name, unsigned int len)
 			break;
 		if (!iskeychar(c))
 			break;
+		/* Correct typing errors about dash or underscore */
+		if (has_underscore && c == '-')
+			c = '_';
+		else if (!has_underscore && c == '_')
+			c = '-';
 		name[len++] = c;
 		if (len >= MAXNAME)
 			return -1;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/