linux-kernel - Re: [PATCH 21/26] Input: synaptics-rmi4: Add support for F12

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYpLUhRN7Sf96ySLrJkBd2dfjKdc1QH+Ci4QzyAjGdJ_A@mail.gmail.com>
Date:	Mon, 9 Nov 2015 14:27:58 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Andrew Duggan <aduggan@...aptics.com>
Cc:	Linux Input <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Benjamin Tissoires <benjamin.tissoires@...il.com>,
	Christopher Heiny <cheiny@...aptics.com>,
	Stephen Chandler Paul <cpaul@...hat.com>
Subject: Re: [PATCH 21/26] Input: synaptics-rmi4: Add support for F12

On Fri, Nov 6, 2015 at 12:42 AM, Andrew Duggan <aduggan@...aptics.com> wrote:

> Function 12 implements 2D touch position sensor for newer Synaptics touch
> devices. It replaces F11 and no device will contain both functions.
>
> Signed-off-by: Andrew Duggan <aduggan@...aptics.com>
(...)
> +config RMI4_F12
> +       bool "RMI4 Function 12 (2D pointing)"
> +       depends on RMI4_2D_SENSOR

So this properly depends on RMI4_2D_SENSOR (you missed this for F11
IIUC).

But I think the approach to have it select RMI4_2D_SENSOR (which is
to be hidden) is a better approach.

This stand-alone F12 patch is nice though, that is how all patches
should look: add a function.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/