linux-kernel - Re: regulator: build warning in regulator_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151110083644.GA12392@sirena.org.uk>
Date:	Tue, 10 Nov 2015 08:36:44 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Frank Rowand <frowand.list@...il.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: regulator: build warning in regulator_lock_supply()

On Mon, Nov 09, 2015 at 07:21:48PM -0800, Frank Rowand wrote:
> In the current Linus tree, new build warning.

> When CONFIG_DEBUG_LOCK_ALLOC is not enabled,

>   drivers/regulator/core.c: In function 'regulator_lock_supply':
>   drivers/regulator/core.c:142:6: warning: unused variable 'i' [-Wunused-variable]

> Introduced by commit

>   9f01cd4a915e1 ("regulator: core: introduce function to lock regulators and its supplies")

There was dome discussion about fixing the lockdep code so this doesn't
happen (since it's perfectly natural code).  I didn't follow where that
went, there was a distraction about the user being buggy which was
addressed.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)