linux-kernel - RE: [PATCH] of: Print rather than WARN'ing when overlap check fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Nov 2015 09:41:18 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Michael Ellerman' <mpe@...erman.id.au>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>
CC:	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"frowand.list@...il.com" <frowand.list@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linuxppc-dev@...abs.org" <linuxppc-dev@...abs.org>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"mitchelh@...eaurora.org" <mitchelh@...eaurora.org>
Subject: RE: [PATCH] of: Print rather than WARN'ing when overlap check fails

From: Michael Ellerman
> Sent: 10 November 2015 05:09
> __rmem_check_for_overlap() is called very early in boot, and on some
> powerpc systems it's not safe to call WARN that early in boot.
> 
> If the overlap check fails the system will oops instead of printing a
> warning. Furthermore because it's so early in boot the console is not up
> and the user doesn't see the oops, they just get a dead system.

Wouldn't it be better to add the required checks to WARN()?
That would stop the same problem happening elsewhere.

	David