lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 09 Nov 2015 17:40:34 -0700 From: Toshi Kani <toshi.kani@....com> To: Boris Ostrovsky <boris.ostrovsky@...cle.com>, "Kirill A. Shutemov" <kirill@...temov.name> Cc: hpa@...or.com, tglx@...utronix.de, mingo@...hat.com, akpm@...ux-foundation.org, bp@...en8.de, linux-mm@...ck.org, linux-kernel@...r.kernel.org, x86@...nel.org, jgross@...e.com, konrad.wilk@...cle.com, elliott@....com Subject: Re: [PATCH v4 RESEND 4/11] x86/asm: Fix pud/pmd interfaces to handle large PAT bit On Mon, 2015-11-09 at 16:18 -0700, Toshi Kani wrote: > On Mon, 2015-11-09 at 17:36 -0500, Boris Ostrovsky wrote: > > On 11/09/2015 03:47 PM, Kirill A. Shutemov wrote: > > > On Mon, Nov 09, 2015 at 02:39:31PM -0500, Boris Ostrovsky wrote: > > > > On 11/09/2015 02:16 PM, Toshi Kani wrote: : > > > > > > > > FWIW, it looks like pmd_pfn_mask() inline is causing this. Reverting it > > > > alone makes this crash go away. > > > Could you check the patch below? > > > > > > I does fix the problem on baremetal, thanks. My 32-bit Xen guests still > > fail which I thought was the same issue but now that I looked at it more > > carefully it has different signature. > > I do not think Xen is hitting this, but I think page_level_mask() has the same > issue for a long time. I will set up 32-bit env on a system with >4GB memory > to verify this. As Kirill explained me in his code review comment for *PAGE_MASK, page_level_mas k() is fine as it is used for virtual addresses. -Toshi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists