linux-kernel - Re: [PATCH v2 4/7] xen: introduce XENPF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1511101442391.5676@kaball.uk.xensource.com>
Date:	Tue, 10 Nov 2015 14:43:26 +0000
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	<linux-arm-kernel@...ts.infradead.org>,
	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	<xen-devel@...ts.xensource.com>, <Ian.Campbell@...rix.com>,
	<konrad.wilk@...cle.com>, <linux-kernel@...r.kernel.org>,
	<david.vrabel@...rix.com>, <boris.ostrovsky@...cle.com>
Subject: Re: [PATCH v2 4/7] xen: introduce XENPF_settime64

On Tue, 10 Nov 2015, Arnd Bergmann wrote:
> On Tuesday 10 November 2015 11:57:52 Stefano Stabellini wrote:
> > Rename the current XENPF_settime hypercall and related struct to
> > XENPF_settime32.
> > 
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@...citrix.com>
> > CC: konrad.wilk@...cle.com
> > CC: david.vrabel@...rix.com
> > CC: boris.ostrovsky@...cle.com
> 
> Looks good.

Can I add your acked-by?


> > ---
> >  arch/x86/xen/time.c              |    8 ++++----
> >  include/xen/interface/platform.h |   18 ++++++++++++++----
> >  2 files changed, 18 insertions(+), 8 deletions(-)
> > 
> > diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
> > index 663c2ea..3bbd377 100644
> > --- a/arch/x86/xen/time.c
> > +++ b/arch/x86/xen/time.c
> > @@ -134,10 +134,10 @@ static int xen_pvclock_gtod_notify(struct notifier_block *nb,
> >         if (!was_set && timespec_compare(&now, &next_sync) < 0)
> >                 return NOTIFY_OK;
> >  
> > -       op.cmd = XENPF_settime;
> > -       op.u.settime.secs = now.tv_sec;
> > -       op.u.settime.nsecs = now.tv_nsec;
> > -       op.u.settime.system_time = xen_clocksource_read();
> > +       op.cmd = XENPF_settime32;
> > +       op.u.settime32.secs = now.tv_sec;
> > +       op.u.settime32.nsecs = now.tv_nsec;
> > +       op.u.settime32.system_time = xen_clocksource_read();
> >  
> >         (void)HYPERVISOR_platform_op(&op);
> 
> I suppose someone will have to get back to this eventually and
> change the code to try XENPF_settime64 first.

I'll leave that to the x86 maintainers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/