lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Nov 2015 21:54:21 +0200 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> Cc: Dave Penkler <dpenkler@...il.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, peter.chen@...escale.com, teuniz@...il.com, USB <linux-usb@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, dpenkler@...il.org Subject: Re: [PATCH v3 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation. On Wed, Nov 11, 2015 at 9:48 PM, Sergei Shtylyov <sergei.shtylyov@...entembedded.com> wrote: > On 11/11/2015 10:03 PM, Andy Shevchenko wrote: >> Won't comment precisely by line, but common nitpicks about style: >> - added empty lines where no need >> - redundant parens >> - pieces of code takes whole line when they are quite fit tail of >> previous one. >> >> And why malloc for 8 bytes? > It's a good tone to skip the parts you're not commenting on, so others > wouldn't have to scroll in vain. Isn't obvious from my comment that no scroll is needed? -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists