linux-kernel - Re: [PATCH v3 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Nov 2015 13:08:57 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Dave Penkler <dpenkler@...il.com>, peter.chen@...escale.com,
	teuniz@...il.com, USB <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	dpenkler@...il.org
Subject: Re: [PATCH v3 1/5] Implement an ioctl to support the USMTMC-USB488
 READ_STATUS_BYTE operation.

On Wed, Nov 11, 2015 at 09:03:14PM +0200, Andy Shevchenko wrote:
> On Wed, Nov 11, 2015 at 1:16 PM, Dave Penkler <dpenkler@...il.com> wrote:
> > Background:
> > When performing a read on an instrument that is executing a function
> > that runs longer than the USB timeout the instrument may hang and require
> > a device reset to recover. The READ_STATUS_BYTE operation always returns
> > even when the instrument is busy permitting to poll for the appropriate
> > condition. This capability is refered to in instrument application notes
> > on synchronizing acquisitions for other platforms.
> >
> 
> Won't comment precisely by line, but common nitpicks about style:
>  - added empty lines where no need
>  - redundant parens
>  - pieces of code takes whole line when they are quite fit tail of previous one.
> 
> And why malloc for 8 bytes?

That's a requirement of the USB stack, any data you send on it has to be
malloced.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/