linux-kernel - Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24593.1447323339@warthog.procyon.org.uk>
Date:	Thu, 12 Nov 2015 10:15:39 +0000
From:	David Howells <dhowells@...hat.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	dhowells@...hat.com, Al Viro <viro@...iv.linux.org.uk>,
	linux-cachefs@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page()

Geert Uytterhoeven <geert@...ux-m68k.org> wrote:

> -	int ret;
> +	int ret = 0;

This isn't quite the right solution.  The uninitialised error path needs to
set -ENOBUFS.  Unfortunately, my compiler doesn't show a warning:-/

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/