linux-kernel - Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVAreJEjXpcrfSOrFT2yS51jedj9NPACBq3e67qYjnGsQ@mail.gmail.com>
Date:	Thu, 12 Nov 2015 11:23:41 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	David Howells <dhowells@...hat.com>
Cc:	Al Viro <viro@...iv.linux.org.uk>, linux-cachefs@...hat.com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page()

Hi David,

On Thu, Nov 12, 2015 at 11:15 AM, David Howells <dhowells@...hat.com> wrote:
> Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
>> -     int ret;
>> +     int ret = 0;
>
> This isn't quite the right solution.  The uninitialised error path needs to
> set -ENOBUFS.

That's what your commit 102f4d900c9c8f5e ("FS-Cache: Handle a write to the
page immediately beyond the EOF marker") does, and is also in its commit
description:

    Whilst we're at it, change the triggered assertion in CacheFiles to just
    return -ENOBUFS instead.

"ret" is used only to print the original error in a debug message.

> Unfortunately, my compiler doesn't show a warning:-/

Need old gcc (4.1.2 ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/