linux-kernel - Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20907.1447324973@warthog.procyon.org.uk>
Date:	Thu, 12 Nov 2015 10:42:53 +0000
From:	David Howells <dhowells@...hat.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	dhowells@...hat.com, Al Viro <viro@...iv.linux.org.uk>,
	linux-cachefs@...hat.com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page()

Geert Uytterhoeven <geert@...ux-m68k.org> wrote:

> > This isn't quite the right solution.  The uninitialised error path needs to
> > set -ENOBUFS.
> 
> That's what your commit 102f4d900c9c8f5e ("FS-Cache: Handle a write to the
> page immediately beyond the EOF marker") does, and is also in its commit
> description:
> 
>     Whilst we're at it, change the triggered assertion in CacheFiles to just
>     return -ENOBUFS instead.
> 
> "ret" is used only to print the original error in a debug message.

I'll adjust your patch to set the default value in ret to be -ENOBUFS instead
of 0.

> > Unfortunately, my compiler doesn't show a warning:-/
> 
> Need old gcc (4.1.2 ;-)

Quite possibly - gcc-5.1 does seem to be a bit lacking in detection of such
things.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/