lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 14 Nov 2015 12:13:44 +0530 From: Sudip Mukherjee <sudipm.mukherjee@...il.com> To: Nizam Haider <nizamhaider786@...il.com> Cc: lidza.louina@...il.com, markh@...pro.net, gregkh@...uxfoundation.org, driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org, Nizam Haider <nijamh@...c.in> Subject: Re: [PATCH v2 4/5] Staging: dgnc: dgnc_neo.c Braces {} should be used on all arms of this statement On Fri, Nov 13, 2015 at 09:03:56PM +0530, Nizam Haider wrote: > Fix Checlpatch warning > HECK: braces {} should be used on all arms of this statement > > Signed-off-by: Nizam Haider <nijamh@...c.in> > --- > drivers/staging/dgnc/dgnc_neo.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c > index e980150..99b230f 100644 > --- a/drivers/staging/dgnc/dgnc_neo.c > +++ b/drivers/staging/dgnc/dgnc_neo.c > @@ -1108,9 +1108,10 @@ static void neo_copy_data_from_uart_to_queue(struct channel_t *ch) > * On the other hand, if the UART IS in FIFO mode, then ask > * the UART to give us an approximation of data it has RX'ed. > */ > - if (!(ch->ch_flags & CH_FIFO_ENABLED)) > + if (!(ch->ch_flags & CH_FIFO_ENABLED)) { > total = 0; > - else { > + } > + else { This should be: diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c index e980150..67e2667 100644 --- a/drivers/staging/dgnc/dgnc_neo.c +++ b/drivers/staging/dgnc/dgnc_neo.c @@ -1108,9 +1108,9 @@ static void neo_copy_data_from_uart_to_queue(struct channel_t *ch) * On the other hand, if the UART IS in FIFO mode, then ask * the UART to give us an approximation of data it has RX'ed. */ - if (!(ch->ch_flags & CH_FIFO_ENABLED)) + if (!(ch->ch_flags & CH_FIFO_ENABLED)) { total = 0; - else { + } else { total = readb(&ch->ch_neo_uart->rfifo); /* regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists