linux-kernel - Re: [PATCH] Rtc: rtc-gemini.c: Remove unnecessary platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1511151156060.15993@T520.local>
Date:	Sun, 15 Nov 2015 11:57:08 +0100 (CET)
From:	Hans Ulli Kroll <ulli.kroll@...il.com>
To:	Nizam Haider <nizamhaider786@...il.com>
cc:	ulli.kroll@...glemail.com, a.zummo@...ertech.it,
	alexandre.belloni@...e-electrons.com,
	linux-arm-kernel@...ts.infradead.org, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org, Nizam Haider <nijamh@...c.in>
Subject: Re: [PATCH] Rtc: rtc-gemini.c: Remove unnecessary
 platform_set_drvdata()

On Sat, 14 Nov 2015, Nizam Haider wrote:

> The driver core clears the driver data to NULL after device_release
> or on probe failure
> 
> Signed-off-by: Nizam Haider <nijamh@...c.in>
> ---
>  drivers/rtc/rtc-gemini.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-gemini.c b/drivers/rtc/rtc-gemini.c
> index e841846..f46b6d4 100644
> --- a/drivers/rtc/rtc-gemini.c
> +++ b/drivers/rtc/rtc-gemini.c
> @@ -156,7 +156,6 @@ static int gemini_rtc_remove(struct platform_device *pdev)
>  	struct gemini_rtc *rtc = platform_get_drvdata(pdev);
>  
>  	rtc_device_unregister(rtc->rtc_dev);
> -	platform_set_drvdata(pdev, NULL);
>  
>  	return 0;
>  }
> -- 
> 1.8.1.4
> 
> 

Acked-by: Hans Ulli Kroll <ulli.kroll@...glemail.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/