linux-kernel - Re: Endless getdents() in vfat filesystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56486709.7000004@oracle.com>
Date:	Sun, 15 Nov 2015 12:05:45 +0100
From:	Vegard Nossum <vegard.nossum@...cle.com>
To:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Richard Weinberger <richard@....at>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Endless getdents() in vfat filesystem

On 11/14/2015 07:19 PM, OGAWA Hirofumi wrote:
> Richard Weinberger <richard@....at> writes:
>
>>>> Yes, it does fixes the problem here, but I can't really comment on the
>>>> correctness of the patch.
>>>>
>>>> Thanks for the quick reponse,
>>>
>>> I made cleanup and made sure fake_offset is corrected.
>>>
>>> Richard, Signed-off-by was missed in your patch, so I added. Can you
>>> agree to Signed-off-by?
>>
>> Sure!
>
> Attached updated patch made smaller changes, and with missed Cc: stable.
>
> Andrew, please queue this up.
>
> Thanks.
>

It would be nice to have a proper patch description too. How about this?

"""
For the root directory, . and .. are faked (using dir_emit_dots()) and
ctx->pos is reset from 2 to 0.

A corrupted root directory could cause fat_get_entry() to fail, but
->iterate() (fat_readdir()) reports progress to the VFS (with ctx->pos
rewound to 0), so any following calls to ->iterate() continue to return
the same entries again and again.

The result is that userspace will never see the end of the directory,
causing e.g. 'ls' to hang in a getdents() loop.
"""

Thanks,


Vegard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/