lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 14 Nov 2015 19:32:25 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	"David S. Miller" <davem@...emloft.net>,
	Hideaki Yoshfuji <yoshfuji@...ux-ipv6.org>,
	James Morris <jmorris@...ei.org>,
	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org, coreteam@...filter.org,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] net-ipv6: Delete unnecessary checks before the function
 call "kfree_skb"

On Sat, 2015-11-14 at 20:05 +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sat, 14 Nov 2015 19:55:00 +0100
> 
> The kfree_skb() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the calls is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  net/ipv6/af_inet6.c                     | 7 ++-----
>  net/ipv6/netfilter/nf_conntrack_reasm.c | 3 +--
>  2 files changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c
> index 44bb66b..4cd9259 100644
> --- a/net/ipv6/af_inet6.c
> +++ b/net/ipv6/af_inet6.c
> @@ -416,12 +416,9 @@ void inet6_destroy_sock(struct sock *sk)
>  	/* Release rx options */
>  
>  	skb = xchg(&np->pktoptions, NULL);
> -	if (skb)
> -		kfree_skb(skb);
> -
> +	kfree_skb(skb);
>  	skb = xchg(&np->rxpmtu, NULL);
> -	if (skb)
> -		kfree_skb(skb);
> +	kfree_skb(skb);
>  

There is no 'issue' here, or not this one.

In most cases, these pointers are NULL, so the test can be predicted by
the processor.

While if the test is done in kfree_skb(), the branch predictor of the
cpu wont be able to predict things.

By feeding too many NULL pointers to kfree_skb(), we slow down it.

Branch misses and hits were considered important years ago...

But seeing this inet6_destroy_sock() is (ab)using xchg() three times, I
am not sure author cared that much about performance.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists