lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 15 Nov 2015 07:17:46 +0100 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: Eric Dumazet <eric.dumazet@...il.com> Cc: Alexey Kuznetsov <kuznet@....inr.ac.ru>, "David S. Miller" <davem@...emloft.net>, Hideaki Yoshfuji <yoshfuji@...ux-ipv6.org>, James Morris <jmorris@...ei.org>, Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>, Pablo Neira Ayuso <pablo@...filter.org>, Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org, netfilter-devel@...r.kernel.org, coreteam@...filter.org, LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr> Subject: Re: net-ipv6: Delete unnecessary checks before the function call "kfree_skb" > While if the test is done in kfree_skb(), the branch predictor of the > cpu wont be able to predict things. > > By feeding too many NULL pointers to kfree_skb(), we slow down it. Would it make sense to annotate checks before such function calls as "UNLIKELY"? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists