linux-kernel - Re: [PATCH 4/7] mm/vmscan: page_is_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1511160209060.18751@chino.kir.corp.google.com>
Date:	Mon, 16 Nov 2015 02:10:10 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Yaowei Bai <baiyaowei@...s.chinamobile.com>
cc:	akpm@...ux-foundation.org, bhe@...hat.com,
	dan.j.williams@...el.com, dave.hansen@...ux.intel.com,
	dave@...olabs.net, dhowells@...hat.com, dingel@...ux.vnet.ibm.com,
	hannes@...xchg.org, hillf.zj@...baba-inc.com, holt@....com,
	iamjoonsoo.kim@....com, joe@...ches.com, kuleshovmail@...il.com,
	mgorman@...e.de, mhocko@...e.cz, mike.kravetz@...cle.com,
	n-horiguchi@...jp.nec.com, penberg@...nel.org,
	sasha.levin@...cle.com, tj@...nel.org, tony.luck@...el.com,
	vbabka@...e.cz, vdavydov@...allels.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/7] mm/vmscan: page_is_file_cache can be boolean

On Mon, 16 Nov 2015, Yaowei Bai wrote:

> diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h
> index cf55945..af73135 100644
> --- a/include/linux/mm_inline.h
> +++ b/include/linux/mm_inline.h
> @@ -8,8 +8,8 @@
>   * page_is_file_cache - should the page be on a file LRU or anon LRU?
>   * @page: the page to test
>   *
> - * Returns 1 if @page is page cache page backed by a regular filesystem,
> - * or 0 if @page is anonymous, tmpfs or otherwise ram or swap backed.
> + * Returns true if @page is page cache page backed by a regular filesystem,
> + * or false if @page is anonymous, tmpfs or otherwise ram or swap backed.
>   * Used by functions that manipulate the LRU lists, to sort a page
>   * onto the right LRU list.
>   *
> @@ -17,7 +17,7 @@
>   * needs to survive until the page is last deleted from the LRU, which
>   * could be as far down as __page_cache_release.
>   */
> -static inline int page_is_file_cache(struct page *page)
> +static inline bool page_is_file_cache(struct page *page)
>  {
>  	return !PageSwapBacked(page);
>  }

Since page_is_file_cache() is often used to determine which zlc to 
increment or decrement (usage such as 
NR_ISOLATED_ANON + page_is_file_cache(page)), I don't think this style is 
helpful.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/