linux-kernel - Re: [PATCH 1/7] ipc/shm: is_file_shm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151116123927.GB14116@dhcp22.suse.cz>
Date:	Mon, 16 Nov 2015 13:39:27 +0100
From:	Michal Hocko <mhocko@...nel.org>
To:	Yaowei Bai <baiyaowei@...s.chinamobile.com>
Cc:	akpm@...ux-foundation.org, bhe@...hat.com,
	dan.j.williams@...el.com, dave.hansen@...ux.intel.com,
	dave@...olabs.net, dhowells@...hat.com, dingel@...ux.vnet.ibm.com,
	hannes@...xchg.org, hillf.zj@...baba-inc.com, holt@....com,
	iamjoonsoo.kim@....com, joe@...ches.com, kuleshovmail@...il.com,
	mgorman@...e.de, mike.kravetz@...cle.com,
	n-horiguchi@...jp.nec.com, penberg@...nel.org, rientjes@...gle.com,
	sasha.levin@...cle.com, tj@...nel.org, tony.luck@...el.com,
	vbabka@...e.cz, vdavydov@...allels.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] ipc/shm: is_file_shm_hugepages can be boolean

On Mon 16-11-15 14:51:20, Yaowei Bai wrote:
> This patch makes is_file_shm_hugepages return bool to improve
> readability due to this particular function only using either
> one or zero as its return value.

yes it makes sense here.

> No functional change.
> 
> Signed-off-by: Yaowei Bai <baiyaowei@...s.chinamobile.com>

Acked-by: Michal Hocko <mhocko@...e.com>

> ---
>  include/linux/shm.h | 6 +++---
>  ipc/shm.c           | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/linux/shm.h b/include/linux/shm.h
> index 6fb8016..04e8818 100644
> --- a/include/linux/shm.h
> +++ b/include/linux/shm.h
> @@ -52,7 +52,7 @@ struct sysv_shm {
>  
>  long do_shmat(int shmid, char __user *shmaddr, int shmflg, unsigned long *addr,
>  	      unsigned long shmlba);
> -int is_file_shm_hugepages(struct file *file);
> +bool is_file_shm_hugepages(struct file *file);
>  void exit_shm(struct task_struct *task);
>  #define shm_init_task(task) INIT_LIST_HEAD(&(task)->sysvshm.shm_clist)
>  #else
> @@ -66,9 +66,9 @@ static inline long do_shmat(int shmid, char __user *shmaddr,
>  {
>  	return -ENOSYS;
>  }
> -static inline int is_file_shm_hugepages(struct file *file)
> +static inline bool is_file_shm_hugepages(struct file *file)
>  {
> -	return 0;
> +	return false;
>  }
>  static inline void exit_shm(struct task_struct *task)
>  {
> diff --git a/ipc/shm.c b/ipc/shm.c
> index 4178727..ed3027d 100644
> --- a/ipc/shm.c
> +++ b/ipc/shm.c
> @@ -459,7 +459,7 @@ static const struct file_operations shm_file_operations_huge = {
>  	.fallocate	= shm_fallocate,
>  };
>  
> -int is_file_shm_hugepages(struct file *file)
> +bool is_file_shm_hugepages(struct file *file)
>  {
>  	return file->f_op == &shm_file_operations_huge;
>  }
> -- 
> 1.9.1
> 
> 

-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/