[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20151116124043.GC14116@dhcp22.suse.cz>
Date: Mon, 16 Nov 2015 13:40:44 +0100
From: Michal Hocko <mhocko@...nel.org>
To: Yaowei Bai <baiyaowei@...s.chinamobile.com>
Cc: akpm@...ux-foundation.org, bhe@...hat.com,
dan.j.williams@...el.com, dave.hansen@...ux.intel.com,
dave@...olabs.net, dhowells@...hat.com, dingel@...ux.vnet.ibm.com,
hannes@...xchg.org, hillf.zj@...baba-inc.com, holt@....com,
iamjoonsoo.kim@....com, joe@...ches.com, kuleshovmail@...il.com,
mgorman@...e.de, mike.kravetz@...cle.com,
n-horiguchi@...jp.nec.com, penberg@...nel.org, rientjes@...gle.com,
sasha.levin@...cle.com, tj@...nel.org, tony.luck@...el.com,
vbabka@...e.cz, vdavydov@...allels.com, linux-mm@...ck.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] mm/hugetlb: is_file_hugepages can be boolean
On Mon 16-11-15 14:51:21, Yaowei Bai wrote:
> This patch makes is_file_hugepages return bool to improve
> readability due to this particular function only using either
> one or zero as its return value.
>
> This patch also removed the if condition to make is_file_hugepages
> return directly.
>
> No functional change.
>
> Signed-off-by: Yaowei Bai <baiyaowei@...s.chinamobile.com>
I think this could be squashed into the previous patch.
Acked-by: Michal Hocko <mhocko@...e.com>
> ---
> include/linux/hugetlb.h | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index 685c262..204c7f5 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -265,20 +265,18 @@ struct file *hugetlb_file_setup(const char *name, size_t size, vm_flags_t acct,
> struct user_struct **user, int creat_flags,
> int page_size_log);
>
> -static inline int is_file_hugepages(struct file *file)
> +static inline bool is_file_hugepages(struct file *file)
> {
> if (file->f_op == &hugetlbfs_file_operations)
> - return 1;
> - if (is_file_shm_hugepages(file))
> - return 1;
> + return true;
>
> - return 0;
> + return is_file_shm_hugepages(file);
> }
>
>
> #else /* !CONFIG_HUGETLBFS */
>
> -#define is_file_hugepages(file) 0
> +#define is_file_hugepages(file) false
> static inline struct file *
> hugetlb_file_setup(const char *name, size_t size, vm_flags_t acctflag,
> struct user_struct **user, int creat_flags,
> --
> 1.9.1
>
>
--
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists