[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5649BDF5.5040405@users.sourceforge.net>
Date: Mon, 16 Nov 2015 12:28:53 +0100
From: SF Markus Elfring <elfring@...rs.sourceforge.net>
To: netdev@...r.kernel.org, Krzysztof Halasa <khalasa@...p.pl>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
Julia Lawall <julia.lawall@...6.fr>
Subject: [PATCH] ixp4xx_eth: Delete an unnecessary check before the function
call "dma_pool_destroy"
From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Mon, 16 Nov 2015 12:23:23 +0100
The dma_pool_destroy() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
drivers/net/ethernet/xscale/ixp4xx_eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c b/drivers/net/ethernet/xscale/ixp4xx_eth.c
index 5138407..6705951 100644
--- a/drivers/net/ethernet/xscale/ixp4xx_eth.c
+++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c
@@ -1192,7 +1192,7 @@ static void destroy_queues(struct port *port)
port->desc_tab = NULL;
}
- if (!ports_open && dma_pool) {
+ if (!ports_open) {
dma_pool_destroy(dma_pool);
dma_pool = NULL;
}
--
2.6.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists