linux-kernel - Re: [PATCH] comedi: dmm32at: Fix coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151116144331.GI18797@mwanda>
Date:	Mon, 16 Nov 2015 17:43:31 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Ranjith Thangavel <ranjithece24@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	abbotti@....co.uk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] comedi: dmm32at: Fix coding style - use BIT macro

This one is buggy.  For example:

> -#define DMM32AT_FIFO_STATUS_PAGE_MASK	(3 << 0)
> +#define DMM32AT_FIFO_STATUS_PAGE_MASK	0

There are other bugs as well.  Please, be more careful.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/