linux-kernel - Re: [PATCH 6/7] mm/gfp: make gfp_zonelist return directly and bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Nov 2015 16:29:42 +0800
From:	Yaowei Bai <baiyaowei@...s.chinamobile.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	akpm@...ux-foundation.org, bhe@...hat.com,
	dan.j.williams@...el.com, dave.hansen@...ux.intel.com,
	dave@...olabs.net, dhowells@...hat.com, dingel@...ux.vnet.ibm.com,
	hannes@...xchg.org, hillf.zj@...baba-inc.com, holt@....com,
	iamjoonsoo.kim@....com, joe@...ches.com, kuleshovmail@...il.com,
	mgorman@...e.de, mhocko@...e.cz, mike.kravetz@...cle.com,
	n-horiguchi@...jp.nec.com, penberg@...nel.org,
	sasha.levin@...cle.com, tj@...nel.org, tony.luck@...el.com,
	vbabka@...e.cz, vdavydov@...allels.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] mm/gfp: make gfp_zonelist return directly and bool

On Mon, Nov 16, 2015 at 09:44:11PM -0800, David Rientjes wrote:
> On Tue, 17 Nov 2015, Yaowei Bai wrote:
> 
> > diff --git a/include/linux/gfp.h b/include/linux/gfp.h
> > index 6523109..14a6249 100644
> > --- a/include/linux/gfp.h
> > +++ b/include/linux/gfp.h
> > @@ -378,9 +378,9 @@ static inline enum zone_type gfp_zone(gfp_t flags)
> >  static inline int gfp_zonelist(gfp_t flags)
> >  {
> >         if (IS_ENABLED(CONFIG_NUMA) && unlikely(flags & __GFP_THISNODE))
> > -               return 1;
> > +               return ZONELIST_NOFALLBACK;
> >  
> > -       return 0;
> > +       return ZONELIST_FALLBACK;
> >  }
> >  
> >  /*
> > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> > index e23a9e7..9664d6c 100644
> > --- a/include/linux/mmzone.h
> > +++ b/include/linux/mmzone.h
> > @@ -576,8 +576,6 @@ static inline bool zone_is_empty(struct zone *zone)
> >  /* Maximum number of zones on a zonelist */
> >  #define MAX_ZONES_PER_ZONELIST (MAX_NUMNODES * MAX_NR_ZONES)
> >  
> > -#ifdef CONFIG_NUMA
> > -
> >  /*
> >   * The NUMA zonelists are doubled because we need zonelists that restrict the
> >   * allocations to a single node for __GFP_THISNODE.
> > @@ -585,10 +583,13 @@ static inline bool zone_is_empty(struct zone *zone)
> >   * [0] : Zonelist with fallback
> >   * [1] : No fallback (__GFP_THISNODE)
> >   */
> > -#define MAX_ZONELISTS 2
> > -#else
> > -#define MAX_ZONELISTS 1
> > +enum {
> > +       ZONELIST_FALLBACK,
> > +#ifdef CONFIG_NUMA
> > +       ZONELIST_NOFALLBACK,
> >  #endif
> > +       MAX_ZONELISTS
> > +};
> >  
> >  /*
> >   * This struct contains information about a zone in a zonelist. It is stored
> 
> This is a different change than the original. 

The original patch doesn't make sense as you said so let's drop it.

> I don't see a benefit from 
> it, but I have no strong feelings on it.  If someone else finds value in 
> this, please update the comment when defining the enum as well.

OK, i'll send a update patch to review first and if nobody disagrees with it i will
resend this patchset.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/