linux-kernel - Re: [PATCH] perf record: Support custom vmlinux path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151117123340.GG22729@kernel.org>
Date:	Tue, 17 Nov 2015 09:33:40 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Wang Nan <wangnan0@...wei.com>
Cc:	masami.hiramatsu.pt@...achi.com, ast@...nel.org,
	lizefan@...wei.com, pi3orama@....com, linux-kernel@...r.kernel.org,
	He Kuang <hekuang@...wei.com>,
	Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH] perf record: Support custom vmlinux path

Em Tue, Nov 17, 2015 at 09:44:44AM +0000, Wang Nan escreveu:
> From: He Kuang <hekuang@...wei.com>
> 
> Make perf-record command support --vmlinux option if BPF_PROLOGUE is on.
> 
> 'perf record' needs vmlinux as the source of DWARF info to generate
> prologue for BPF programs, so path of vmlinux should be specified.
> 
> Short name 'k' has been taken by 'clockid'. This patch skips the short
> option name and use '--vmlinux' for vmlinux path.
> 
> Signed-off-by: He Kuang <hekuang@...wei.com>
> Signed-off-by: Wang Nan <wangnan0@...wei.com>
> Cc: Alexei Starovoitov <ast@...nel.org>
> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> Cc: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Zefan Li <lizefan@...wei.com>
> Cc: pi3orama@....com
> ---
> 
> Hi Arnaldo,
> 
> This patch is a standalone improvement to support BPF argument fetching
> better. Without this patch vmlinux must be reside in standard path
> for BPF loader finding it. I think you can review this patch with other
> patch I send today. Other patch on my local tree is not belong to this
> topic.

Thanks, applying.
 
> Thank you.
> 
> ---
>  tools/perf/builtin-record.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 199fc31..cfd0e14 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -1118,6 +1118,10 @@ struct option __record_options[] = {
>  		   "clang binary to use for compiling BPF scriptlets"),
>  	OPT_STRING(0, "clang-opt", &llvm_param.clang_opt, "clang options",
>  		   "options passed to clang when compiling BPF scriptlets"),
> +#ifdef HAVE_BPF_PROLOGUE
> +	OPT_STRING(0, "vmlinux", &symbol_conf.vmlinux_name,
> +		   "file", "vmlinux pathname"),
> +#endif
>  #endif
>  	OPT_END()
>  };
> -- 
> 1.8.3.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/