linux-kernel - Re: [PATCH] ftrace/x86: Add comment on static function tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151116210333.49fec8de@grimm.local.home>
Date:	Mon, 16 Nov 2015 21:03:33 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	x86@...nel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...nel.org>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ftrace/x86: Add comment on static function tracing

On Tue, 17 Nov 2015 09:43:24 +0900
Namhyung Kim <namhyung@...nel.org> wrote:

> There was a confusion between update_ftrace_function() and static
> function tracing trampoline regarding 3rd parameter (ftrace_ops).
> Add a comment for clarification.
> 
> Suggested-by: Steven Rostedt <rostedt@...dmis.org>

Acked-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve

> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>  arch/x86/kernel/mcount_64.S | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/x86/kernel/mcount_64.S b/arch/x86/kernel/mcount_64.S
> index 94ea120fa21f..87e1762e2bca 100644
> --- a/arch/x86/kernel/mcount_64.S
> +++ b/arch/x86/kernel/mcount_64.S
> @@ -278,6 +278,12 @@ GLOBAL(ftrace_stub)
>  	/* save_mcount_regs fills in first two parameters */
>  	save_mcount_regs
>  
> +	/*
> +	 * When DYNAMIC_FTRACE is not defined, ARCH_SUPPORTS_FTRACE_OPS is not
> +	 * set (see include/asm/ftrace.h and include/linux/ftrace.h).  Only the
> +	 * ip and parent ip are used and the list function is called when
> +	 * function tracing is enabled.
> +	 */
>  	call   *ftrace_trace_function
>  
>  	restore_mcount_regs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/