linux-kernel - [tip:x86/urgent] x86/ftrace: Add comment on static function tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 19 Nov 2015 02:12:31 -0800
From:	tip-bot for Namhyung Kim <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	rostedt@...dmis.org, tglx@...utronix.de, namhyung@...nel.org,
	linux-kernel@...r.kernel.org, hpa@...ux.intel.com, hpa@...or.com,
	mingo@...nel.org
Subject: [tip:x86/urgent] x86/ftrace:
  Add comment on static function tracing

Commit-ID:  112677d683d31ebd6a8e8b02e0620ae512354b2d
Gitweb:     http://git.kernel.org/tip/112677d683d31ebd6a8e8b02e0620ae512354b2d
Author:     Namhyung Kim <namhyung@...nel.org>
AuthorDate: Tue, 17 Nov 2015 09:43:24 +0900
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Thu, 19 Nov 2015 11:07:49 +0100

x86/ftrace: Add comment on static function tracing

There was a confusion between update_ftrace_function() and static
function tracing trampoline regarding 3rd parameter (ftrace_ops).
Add a comment for clarification.

Suggested-by: Steven Rostedt <rostedt@...dmis.org>
Signed-off-by: Namhyung Kim <namhyung@...nel.org>
Cc: H. Peter Anvin <hpa@...ux.intel.com>
Cc: Steven Rostedt <rostedt@...dmis.org>
Link: http://lkml.kernel.org/r/1447721004-2551-1-git-send-email-namhyung@kernel.org
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
---
 arch/x86/kernel/mcount_64.S | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/x86/kernel/mcount_64.S b/arch/x86/kernel/mcount_64.S
index 94ea120..87e1762 100644
--- a/arch/x86/kernel/mcount_64.S
+++ b/arch/x86/kernel/mcount_64.S
@@ -278,6 +278,12 @@ trace:
 	/* save_mcount_regs fills in first two parameters */
 	save_mcount_regs
 
+	/*
+	 * When DYNAMIC_FTRACE is not defined, ARCH_SUPPORTS_FTRACE_OPS is not
+	 * set (see include/asm/ftrace.h and include/linux/ftrace.h).  Only the
+	 * ip and parent ip are used and the list function is called when
+	 * function tracing is enabled.
+	 */
 	call   *ftrace_trace_function
 
 	restore_mcount_regs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/