linux-kernel - Re: [PATCH 7/7] mm/mmzone: refactor memmap_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151117024001.GC5867@yaowei-K42JY>
Date:	Tue, 17 Nov 2015 10:40:01 +0800
From:	Yaowei Bai <baiyaowei@...s.chinamobile.com>
To:	Michal Hocko <mhocko@...nel.org>
Cc:	akpm@...ux-foundation.org, bhe@...hat.com,
	dan.j.williams@...el.com, dave.hansen@...ux.intel.com,
	dave@...olabs.net, dhowells@...hat.com, dingel@...ux.vnet.ibm.com,
	hannes@...xchg.org, hillf.zj@...baba-inc.com, holt@....com,
	iamjoonsoo.kim@....com, joe@...ches.com, kuleshovmail@...il.com,
	mgorman@...e.de, mike.kravetz@...cle.com,
	n-horiguchi@...jp.nec.com, penberg@...nel.org, rientjes@...gle.com,
	sasha.levin@...cle.com, tj@...nel.org, tony.luck@...el.com,
	vbabka@...e.cz, vdavydov@...allels.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/7] mm/mmzone: refactor memmap_valid_within

On Mon, Nov 16, 2015 at 01:45:01PM +0100, Michal Hocko wrote:
> On Mon 16-11-15 14:51:26, Yaowei Bai wrote:
> [...]
> > @@ -72,16 +72,10 @@ struct zoneref *next_zones_zonelist(struct zoneref *z,
> >  }
> >  
> >  #ifdef CONFIG_ARCH_HAS_HOLES_MEMORYMODEL
> > -int memmap_valid_within(unsigned long pfn,
> > +bool memmap_valid_within(unsigned long pfn,
> >  					struct page *page, struct zone *zone)
> >  {
> > -	if (page_to_pfn(page) != pfn)
> > -		return 0;
> > -
> > -	if (page_zone(page) != zone)
> > -		return 0;
> > -
> > -	return 1;
> > +	return page_to_pfn(page) == pfn && page_zone(page) == zone;
> 
> I do not think this is easier to read. Quite contrary

OK, so we can just make it return ture/false without refactoring it.

> 
> >  }
> >  #endif /* CONFIG_ARCH_HAS_HOLES_MEMORYMODEL */
> >  
> > -- 
> > 1.9.1
> > 
> > 
> 
> -- 
> Michal Hocko
> SUSE Labs


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/