linux-kernel - Re: [PATCH v2 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+g4u6qvTDH3FUkZmwkOAptPnie8Mp0r=L8g+JJ-fYKnQ@mail.gmail.com>
Date:	Tue, 17 Nov 2015 11:53:46 -0600
From:	Rob Herring <robh@...nel.org>
To:	"Opensource [Adam Thomson]" <Adam.Thomson.Opensource@...semi.com>
Cc:	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Support Opensource <Support.Opensource@...semi.com>
Subject: Re: [PATCH v2 1/2] ASoC: da7218: Add bindings documentation for
 DA7218 audio codec

On Tue, Nov 17, 2015 at 11:27 AM, Opensource [Adam Thomson]
<Adam.Thomson.Opensource@...semi.com> wrote:
> On November 11, 2015 20:20, Rob Herring wrote:
>
>> > +- dlg,micbias1-lvl : Voltage (mV) for Mic Bias 1
>> > +   [<1200>, <1600>, <1800>, <2000>, <2200>, <2400>, <2600>, <2800>,
>> <3000>]
>> > +- dlg,micbias2-lvl : Voltage (mV) for Mic Bias 2
>> > +   [<1200>, <1600>, <1800>, <2000>, <2200>, <2400>, <2600>, <2800>,
>> <3000>]
>>
>> Units please (-microvolt).
>
> I refer back to our previous discussion (https://lkml.org/lkml/2015/10/8/661).
> This doesn't add anything and makes the binding name unnecessarily long. Why is
> this being enforced? Whoever uses the binding will have to look at the
> documentation to understand which values are valid anyway, so this seems like
> cruft.

It is simply standard, best practice for new bindings. Certainly there
are examples that don't follow this, but they are either old or
escaped review.

Drop the 'lvl' part if you are so concerned about length.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/