linux-kernel - RE: [PATCH v2 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 18 Nov 2015 11:23:53 +0000
From:	"Opensource [Adam Thomson]" <Adam.Thomson.Opensource@...semi.com>
To:	Rob Herring <robh@...nel.org>,
	"Opensource [Adam Thomson]" <Adam.Thomson.Opensource@...semi.com>
CC:	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Support Opensource" <Support.Opensource@...semi.com>
Subject: RE: [PATCH v2 1/2] ASoC: da7218: Add bindings documentation for
 DA7218 audio codec

On November 17, 2015 17:54, Rob Herring wrote:

> >> > +- dlg,micbias1-lvl : Voltage (mV) for Mic Bias 1
> >> > +   [<1200>, <1600>, <1800>, <2000>, <2200>, <2400>, <2600>, <2800>,
> >> <3000>]
> >> > +- dlg,micbias2-lvl : Voltage (mV) for Mic Bias 2
> >> > +   [<1200>, <1600>, <1800>, <2000>, <2200>, <2400>, <2600>, <2800>,
> >> <3000>]
> >>
> >> Units please (-microvolt).
> >
> > I refer back to our previous discussion (https://lkml.org/lkml/2015/10/8/661).
> > This doesn't add anything and makes the binding name unnecessarily long. Why is
> > this being enforced? Whoever uses the binding will have to look at the
> > documentation to understand which values are valid anyway, so this seems like
> > cruft.
> 
> It is simply standard, best practice for new bindings. Certainly there
> are examples that don't follow this, but they are either old or
> escaped review.
> 
> Drop the 'lvl' part if you are so concerned about length.

If this is a standard, then maybe this should be explicitly documented and
pushed to all other maintainers so it isn't escaping review? Otherwise you're
left with a disparity which suggests it isn't standard at all. Personally I
stand by that for device specific bindings this shouldn't apply as it gains
nothing except achieving an overly long binding, or you end up cutting down the
descriptive part of the name to accommodate units at the end.