linux-kernel - Re: [PATCH 4/7] misc: eeprom: 93xx46: Add DT binding for Atmel AT93C46D devices.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151117205652.GA8990@rob-hp-laptop>
Date:	Tue, 17 Nov 2015 14:56:52 -0600
From:	Rob Herring <robh@...nel.org>
To:	Cory Tusar <cory.tusar@...1solutions.com>
Cc:	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org, agust@...x.de,
	gregkh@...uxfoundation.org, jic23@...nel.org, vz@...ia.com,
	broonie@...nel.org, afd@...com, andrew@...n.ch,
	Chris.Healy@....aero, Keith.Vennel@....aero,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/7] misc: eeprom: 93xx46: Add DT binding for Atmel
 AT93C46D devices.

On Mon, Nov 16, 2015 at 11:16:33PM -0500, Cory Tusar wrote:
> This commit adds a compatible string to the eeprom_93xx46 devicetree
> bindings in support of Atmel AT93C46D devices.
> 
> Signed-off-by: Cory Tusar <cory.tusar@...1solutions.com>
> ---
>  Documentation/devicetree/bindings/misc/eeprom-93xx46.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> index ba493a8..34a0cc2 100644
> --- a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> +++ b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> @@ -1,7 +1,7 @@
>  EEPROMs (SPI) compatible with Microchip Technology 93xx46 family.
>  
>  Required properties:
> -- compatible : "eeprom-93xx46"
> +- compatible : "eeprom-93xx46", "atmel,at93c46d"

This needs to be clear that it should be the opposite order. Something 
like this:

compatible: One of the following:
	"atmel,at93c46d"
	Followed by "eeprom-93xx46"

>  - data-size : number of data bits per word (either 8 or 16)
>  
>  Optional properties:
> -- 
> 2.4.10
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/