linux-kernel - Re: [PATCH 6/7] misc: eeprom: 93xx46: Add DT binding for a GPIO 'select' line.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Nov 2015 14:59:01 -0600
From:	Rob Herring <robh@...nel.org>
To:	Cory Tusar <cory.tusar@...1solutions.com>
Cc:	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org, agust@...x.de,
	gregkh@...uxfoundation.org, jic23@...nel.org, vz@...ia.com,
	broonie@...nel.org, afd@...com, andrew@...n.ch,
	Chris.Healy@....aero, Keith.Vennel@....aero,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] misc: eeprom: 93xx46: Add DT binding for a GPIO
 'select' line.

On Mon, Nov 16, 2015 at 11:16:35PM -0500, Cory Tusar wrote:
> This commit documents an additional devicetree binding in the
> eeprom_93x46 driver allowing a GPIO line to function as a 'select'
> or 'enable' signal prior to accessing the EEPROM.

You can just fold all the DT binding patches into 1. They don't have to 
match up to driver changes.

> 
> Signed-off-by: Cory Tusar <cory.tusar@...1solutions.com>
> ---
>  Documentation/devicetree/bindings/misc/eeprom-93xx46.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> index 34a0cc2..75b16f4 100644
> --- a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> +++ b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> @@ -6,6 +6,8 @@ Required properties:
>  
>  Optional properties:
>  - read-only : parameter-less property which disables writes to the EEPROM
> +- select-gpio : if present, specifies the GPIO that will be asserted prior to
> +  each access to the EEPROM (e.g. for SPI bus multiplexing)

This should be "select-gpios".

>  
>  Property rules described in Documentation/devicetree/bindings/spi/spi-bus.txt
>  apply.  In particular, "reg" and "spi-max-frequency" properties must be given.
> @@ -17,4 +19,5 @@ Example:
>  		spi-max-frequency = <1000000>;
>  		spi-cs-high;
>  		data-size = <8>;
> +		select-gpio = <&gpio4 4 GPIO_ACTIVE_HIGH>;
>  	};
> -- 
> 2.4.10
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/