lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 18 Nov 2015 09:44:48 +0900 From: Krzysztof Kozlowski <k.kozlowski@...sung.com> To: Arnd Bergmann <arnd@...db.de>, linux-arm-kernel@...ts.infradead.org Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>, linux-samsung-soc@...r.kernel.org, linux-pm@...r.kernel.org, Viresh Kumar <viresh.kumar@...aro.org>, linux-kernel@...r.kernel.org, Kukjin Kim <kgene@...nel.org> Subject: Re: [PATCH] cpufreq: do not mark s3c2410_plls_add as __init On 17.11.2015 18:01, Arnd Bergmann wrote: > On Tuesday 17 November 2015 10:57:48 Krzysztof Kozlowski wrote: >> On 17.11.2015 07:17, Arnd Bergmann wrote: >>> On Monday 16 November 2015 23:36:42 Rafael J. Wysocki wrote: >>>> >>>> This should go in through the Samsung tree, so I'll leave it for them to pick >>>> it up (at least for the time being). >>> >>> Ok, fair enough. Kukjin or Krzysztof, can you pick this up? >> >> Sure. >> >> As for the patch I think everything can be converted to init/initdata >> (as in attachment). >> > > I don't think so: > > static struct subsys_interface s3c2442_plls169344_interface __initdata = { > .name = "s3c2442_plls169344", > .subsys = &s3c2442_subsys, > .add_dev = s3c2440_plls169344_add, > }; > > This gets passed into subsys_interface_register(), which is not __init > in turn. subsys_interface_register() then goes on to add > s3c2442_plls169344_interface into a linked list that is traversed > at runtime, but the __initdata section gets discarded so you now > have a broken list. Ah, yes, so the patch is fine: Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists