linux-kernel - Re: [PATCH] USB: USB_OTG does not depend on PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5217888.FiujFV8yJj@wuerfel>
Date:	Wed, 18 Nov 2015 10:38:18 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Peter Chen <peter.chen@...escale.com>
Cc:	Felipe Balbi <balbi@...com>, gregkh@...uxfoundation.org,
	linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: USB_OTG does not depend on PM

On Wednesday 18 November 2015 11:17:50 Peter Chen wrote:
> From 3a6918dae038aadc200dcf0263f4440acc2353d4 Mon Sep 17 00:00:00 2001
> From: Peter Chen <peter.chen@...escale.com>
> Date: Wed, 18 Nov 2015 11:06:34 +0800
> Subject: [PATCH 1/1] usb: kconfig: fix warning of select USB_OTG
> 
> When choose randconfig for kernel build, it reports below warning:
> "warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG
> which has unmet direct dependencies (USB_SUPPORT && USB && PM)"
> 
> In fact, USB_OTG is visual symbol and depends on PM, so the driver

                      visible ?

> needs to depend on it to reduce dependency problem.
> 
> Signed-off-by: Peter Chen <peter.chen@...escale.com>
> Reported-by: Arnd Bergmann <arnd@...db.de>
> Cc: Felipe Balbi <balbi@...com>

Acked-by: Arnd Bergmann <arnd@...db.de>

I was a bit worried that this might break defconfig files that now
no longer automatically get OSB_OTG enabled, but I have checked all
defconfig files we have in the kernel and none of them uses
USB_OTG_FSM, FSL_USB2_OTG or USB_MV_OTG, so we are fine.

Thanks!

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/