linux-kernel - Re: [PATCH v2 1/1] i2c: taos-evm: replace simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 18 Nov 2015 10:39:40 +0100
From:	LABBE Corentin <montjoie.mailing@...il.com>
To:	Jean Delvare <jdelvare@...e.de>
Cc:	LABBE Corentin <clabbe.montjoie@...il.com>, wsa@...-dreams.de,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] i2c: taos-evm: replace simple_strtoul by kstrtou8

On Wed, Nov 18, 2015 at 10:29:54AM +0100, Jean Delvare wrote:
> Hi Corentin,
> 
> On Wed, 18 Nov 2015 09:00:53 +0100, LABBE Corentin wrote:
> > The simple_strtoul function is marked as obsolete.
> > This patch replace it by kstrtou8.
> > 
> > Signed-off-by: LABBE Corentin <clabbe.montjoie@...il.com>
> > ---
> >  drivers/i2c/busses/i2c-taos-evm.c | 10 +++++++++-
> >  1 file changed, 9 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/i2c/busses/i2c-taos-evm.c b/drivers/i2c/busses/i2c-taos-evm.c
> > index 4c7fc2d..552f127 100644
> > --- a/drivers/i2c/busses/i2c-taos-evm.c
> > +++ b/drivers/i2c/busses/i2c-taos-evm.c
> > @@ -70,6 +70,7 @@ static int taos_smbus_xfer(struct i2c_adapter *adapter, u16 addr,
> >  	struct serio *serio = adapter->algo_data;
> >  	struct taos_data *taos = serio_get_drvdata(serio);
> >  	char *p;
> > +	int err;
> >  
> >  	/* Encode our transaction. "@" is for the device address, "$" for the
> >  	   SMBus command and "#" for the data. */
> > @@ -130,7 +131,14 @@ static int taos_smbus_xfer(struct i2c_adapter *adapter, u16 addr,
> >  			return 0;
> >  	} else {
> >  		if (p[0] == 'x') {
> > -			data->byte = simple_strtol(p + 1, NULL, 16);
> > +			/*
> > +			 * voluntary dropping error code of kstrtou8 since all
> 
> "Voluntarily" or "Willingly" would be more correct.
> 
> > +			 * error code that it could return are invalid according
> > +			 * to Documentation/i2c/fault-codes
> > +			 */
> > +			err = kstrtou8(p + 1, 16, &data->byte);
> > +			if (err)
> > +				return -EPROTO;
> >  			return 0;
> >  		}
> >  	}
> 
> Thanks for the patch. Note that you don't strictly need the "err"
> variable as you never use its value.
> 
> Reviewed-by: Jean Delvare <jdelvare@...e.de>
> Tested-by: Jean Delvare <jdelvare@...e.de>
> 

Thanks

I will send a v3 without the err and the spell fix.

Regards

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/