linux-kernel - Re: [PATCH] SCSI-libfc: Delete an unnecessary check before the function call "kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1447957288.5825.83.camel@lin-nd1-054.jf.intel.com>
Date:	Thu, 19 Nov 2015 10:21:28 -0800
From:	Vasu Dev <vasu.dev@...ux.intel.com>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:	"James E. J. Bottomley" <JBottomley@...n.com>,
	fcoe-devel@...n-fcoe.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] SCSI-libfc: Delete an unnecessary check before the
 function call "kmem_cache_destroy"

On Mon, 2015-11-16 at 09:45 +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Mon, 16 Nov 2015 09:39:12 +0100
> 
> The kmem_cache_destroy() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/scsi/libfc/fc_fcp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c
> index 5121272..d377514 100644
> --- a/drivers/scsi/libfc/fc_fcp.c
> +++ b/drivers/scsi/libfc/fc_fcp.c
> @@ -2216,8 +2216,7 @@ int fc_setup_fcp(void)
>  
>  void fc_destroy_fcp(void)
>  {
> -	if (scsi_pkt_cachep)
> -		kmem_cache_destroy(scsi_pkt_cachep);
> +	kmem_cache_destroy(scsi_pkt_cachep);
>  }
>  
>  /**
Looks good.

Acked-by: Vasu Dev <vasu.dev@...el.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/