linux-kernel - Re: [PATCH 4/7] netprio_cgroup: limit the maximum css->id to USHRT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <564EE556.5070907@bmw-carit.de>
Date:	Fri, 20 Nov 2015 10:18:14 +0100
From:	Daniel Wagner <daniel.wagner@...-carit.de>
To:	Tejun Heo <tj@...nel.org>, <davem@...emloft.net>,
	<pablo@...filter.org>, <kaber@...sh.net>,
	<kadlec@...ckhole.kfki.hu>, <lizefan@...wei.com>,
	<hannes@...xchg.org>
CC:	<netdev@...r.kernel.org>, <netfilter-devel@...r.kernel.org>,
	<coreteam@...filter.org>, <cgroups@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <kernel-team@...com>,
	<daniel@...earbox.net>, <nhorman@...driver.com>
Subject: Re: [PATCH 4/7] netprio_cgroup: limit the maximum css->id to
 USHRT_MAX

On 11/19/2015 07:52 PM, Tejun Heo wrote:
> netprio builds per-netdev contiguous priomap array which is indexed by
> css->id.  The array is allocated using kzalloc() effectively limiting
> the maximum ID supported to some thousand range.  This patch caps the
> maximum supported css->id to USHRT_MAX which should be way above what
> is actually useable.
> 
> This allows reducing sock->sk_cgrp_prioidx to u16 from u32.  The freed
> up part will be used to overload the cgroup related fields.
> sock->sk_cgrp_prioidx's position is swapped with sk_mark so that the
> two cgroup related fields are adjacent.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Cc: Daniel Borkmann <daniel@...earbox.net>
> Cc: Daniel Wagner <daniel.wagner@...-carit.de>

Acked-by: Daniel Wagner <daniel.wagner@...-carit.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/