linux-kernel - RE: [PATCH v11 3/8] Input: goodix - write configuration data to device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1F3AC3675D538145B1661F571FE1805F2F12029F@irsmsx105.ger.corp.intel.com>
Date:	Fri, 20 Nov 2015 13:13:03 +0000
From:	"Tirdea, Irina" <irina.tirdea@...el.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	Bastien Nocera <hadess@...ess.net>,
	Aleksei Mamlin <mamlinav@...il.com>,
	Karsten Merker <merker@...ian.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	Mark Rutland <mark.rutland@....com>,
	"Rob Herring" <robh+dt@...nel.org>,
	"Purdila, Octavian" <octavian.purdila@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [PATCH v11 3/8] Input: goodix - write configuration data to
 device



> -----Original Message-----
> From: Dmitry Torokhov [mailto:dmitry.torokhov@...il.com]
> Sent: 19 November, 2015 20:21
> To: Tirdea, Irina
> Cc: Bastien Nocera; Aleksei Mamlin; Karsten Merker; linux-input@...r.kernel.org; Mark Rutland; Rob Herring; Purdila, Octavian; linux-
> kernel@...r.kernel.org; devicetree@...r.kernel.org
> Subject: Re: [PATCH v11 3/8] Input: goodix - write configuration data to device
> 
> On Thu, Nov 19, 2015 at 02:26:36PM +0200, Irina Tirdea wrote:
> > +	if (ts->gpiod_int && ts->gpiod_rst) {
> > +		/* update device config */
> > +		ts->cfg_name = kasprintf(GFP_KERNEL, "goodix_%d_cfg.bin",
> > +					 ts->id);
> 
> devm_kasprintf maybe (don't resubmit)?
> 

Yes, using devm_kasprintf would be better.

Thanks,
Irina

> Thanks.
> 
> --
> Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/