lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Nov 2015 10:33:48 +0900 From: Namhyung Kim <namhyung@...nel.org> To: Arnaldo Carvalho de Melo <acme@...nel.org> CC: Ingo Molnar <mingo@...nel.org>, Peter Zijlstra <a.p.zijlstra@...llo.nl>, Jiri Olsa <jolsa@...hat.com>, LKML <linux-kernel@...r.kernel.org>, Brendan Gregg <brendan.d.gregg@...il.com>, David Ahern <dsahern@...il.com>, Frederic Weisbecker <fweisbec@...il.com>, Andi Kleen <andi@...stfloor.org>, Kan Liang <kan.liang@...el.com> Subject: Re: [PATCH v5 2/9] perf callchain: Abstract callchain print function Hi Arnaldo, On Thu, Nov 19, 2015 at 10:41:32AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Nov 09, 2015 at 02:45:39PM +0900, Namhyung Kim escreveu: > > This is a preparation to support for printing other type of callchain > > value like count or period. > > > > Acked-by: Brendan Gregg <brendan.d.gregg@...il.com> > > Signed-off-by: Namhyung Kim <namhyung@...nel.org> > > --- [SNIP] > > +char *callchain_node__sprintf_value(struct callchain_node *node, > > + char *bf, size_t bfsize, u64 total) > > sprintf doesn't require a bfsize, snprintf does, but we don't use that, > so renaming it to callchain_node__scnprintf_value() so that we recall > the semantic associated with this operation. OK, and thank you for doing this! Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists