| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Nov 2015 09:37:15 +0800
From: hl <hl@...k-chips.com>
To: Heiko Stuebner <heiko@...ech.de>
CC: dianders@...omium.org, mturquette@...libre.com,
myungjoo.ham@...sung.com, kyungmin.park@...sung.com,
linux-clk@...r.kernel.org, sboyd@...eaurora.org,
dbasehore@...omium.org, linux-rockchip@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] clk: rockchip: dmc: support rk3399 dmc clock driver
Hi Heiko,
On 20/11/15 05:47, Heiko Stuebner wrote:
> Hi Lin,
>
> Am Donnerstag, 19. November 2015, 18:21:10 schrieb Lin Huang:
>> support rk3399 dmc clock driver. Note, ddr set rate function will
>> use dcf controller which run in ATF, it need to fishish it when rk3399
>> arm trust firmware ready.
> this unfinalized state is slightly unfortunate and I think this code will
> need to wait until CRU and DDRC specs are available.
>
> Because this is clearly part of the CRU (labeled CRU_CLKSEL6_CON etc)
> so shouldn't be a separate driver at all and also what your driver currently
> only does can still simply be described in the regular scheme as part of
> a full clock driver like
>
> PNAME(mux_ddrc_p) = { "pll_dpll", "pll_gpll", "pll_alpll", "pll_abpll" };
> COMPOSITE_NOGATE(0, "ddrc", mux_ddrc_p, 0,
> RK3399_CLKSEL_CON(6), 4, 2, MFLAGS, 0, 3,
> DFLAGS | CLK_DIVIDER_POWER_OF_TWO),
>
> So the code needs to actually demonstrate why a separate clock type is
> really necessary.
>
> I do understand that we will probably need a special way to talk to this
> dcf controller but seeing how this interaction will work is really a
> prequisite to finding a correct solution.
if we can use common clock driver, i can put the dfi controller as
a independent driver
into devfreq, this is the best way. But how do we separate the ddr
clk_set_rate() ,
so we can manipulate dcf controller(actually, we use SMC handle dcf
controller in arm trust firmware ),
i check clock driver code, it seem there is not way to do that for now.
>
> Heiko
>
>> ---
>> drivers/clk/rockchip/Makefile | 1 +
>> drivers/clk/rockchip/clk-rk3399-dmc.c | 196 ++++++++++++++++++++++++++++++++++
>> include/soc/rockchip/rk3399-dmc-clk.h | 36 +++++++
>> 3 files changed, 233 insertions(+)
>> create mode 100644 drivers/clk/rockchip/clk-rk3399-dmc.c
>> create mode 100644 include/soc/rockchip/rk3399-dmc-clk.h
>>
>> diff --git a/drivers/clk/rockchip/Makefile b/drivers/clk/rockchip/Makefile
>> index b27edd6..98bd955 100644
>> --- a/drivers/clk/rockchip/Makefile
>> +++ b/drivers/clk/rockchip/Makefile
>> @@ -13,3 +13,4 @@ obj-$(CONFIG_RESET_CONTROLLER) += softrst.o
>> obj-y += clk-rk3188.o
>> obj-y += clk-rk3288.o
>> obj-y += clk-rk3368.o
>> +obj-y += clk-rk3399-dmc.o
>> diff --git a/drivers/clk/rockchip/clk-rk3399-dmc.c b/drivers/clk/rockchip/clk-rk3399-dmc.c
>> new file mode 100644
>> index 0000000..03cc044
>> --- /dev/null
>> +++ b/drivers/clk/rockchip/clk-rk3399-dmc.c
>> @@ -0,0 +1,196 @@
>> +/*
>> + * Copyright (c) 2014, Fuzhou Rockchip Electronics Co., Ltd
>> + *
>> + * This program is free software; you can redistribute it and/or modify it
>> + * under the terms and conditions of the GNU General Public License,
>> + * version 2, as published by the Free Software Foundation.
>> + *
>> + * This program is distributed in the hope it will be useful, but WITHOUT
>> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
>> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
>> + * more details.
>> + */
>> +
>> +#include <linux/slab.h>
>> +#include <linux/clk.h>
>> +#include <linux/clk-provider.h>
>> +#include <linux/clkdev.h>
>> +#include <linux/io.h>
>> +#include <linux/kernel.h>
>> +#include <linux/module.h>
>> +#include <linux/of.h>
>> +#include <linux/of_address.h>
>> +#include <linux/of_irq.h>
>> +#include <linux/platform_device.h>
>> +#include <soc/rockchip/rk3399-dmc-clk.h>
>> +
>> +#define to_rk3399_dmcclk(obj) container_of(obj, struct rk3399_dmcclk, hw)
>> +
>> +/* CRU_CLKSEL6_CON*/
>> +#define CRU_CLKSEL6_CON 0x118
>> +#define CLK_DDRC_PLL_SEL_SHIFT 0x4
>> +#define CLK_DDRC_PLL_SEL_MASK 0x3
>> +#define CLK_DDRC_DIV_CON_SHIFT 0
>> +#define CLK_DDRC_DIV_CON_MASK 0x07
>> +
>> +static unsigned long rk3399_dmcclk_recalc_rate(struct clk_hw *hw,
>> + unsigned long parent_rate)
>> +{
>> + struct rk3399_dmcclk *dmc = to_rk3399_dmcclk(&hw);
>> + u32 val;
>> +
>> + /*
>> + * Get parent rate since it changed in this clks set_rate op. The parent
>> + * rate passed into this function is cached before set_rate is called in
>> + * the common clk code, so we have to get it here.
>> + */
>> + parent_rate = clk_get_rate(clk_get_parent(hw->clk));
>> +
>> + val = readl(dmc->cru + CRU_CLKSEL6_CON);
>> + val = (val >> CLK_DDRC_DIV_CON_SHIFT) & CLK_DDRC_DIV_CON_MASK;
>> +
>> + return parent_rate / (val + 1);
>> +}
>> +
>> +/*
>> + * TODO: set ddr frequcney in dcf which run in ATF
>> + */
>> +static int rk3399_dmcclk_set_rate(struct clk_hw *hw, unsigned long rate,
>> + unsigned long parent_rate)
>> +{
>> + return 0;
>> +}
>> +
>> +static u8 rk3399_dmcclk_get_parent(struct clk_hw *hw)
>> +{
>> + struct rk3399_dmcclk *dmc = to_rk3399_dmcclk(&hw);
>> + u32 val;
>> +
>> + val = readl(dmc->cru + CRU_CLKSEL6_CON);
>> +
>> + return (val >> CLK_DDRC_PLL_SEL_SHIFT) &
>> + CLK_DDRC_PLL_SEL_MASK;
>> +}
>> +
>> +static const struct clk_ops rk3399_dmcclk_ops = {
>> + .recalc_rate = rk3399_dmcclk_recalc_rate,
>> + .set_rate = rk3399_dmcclk_set_rate,
>> + .get_parent = rk3399_dmcclk_get_parent,
>> +};
>> +
>> +static const char *parent_clk_names[] = {
>> + "pll_dpll",
>> + "pll_gpll",
>> + "pll_alpll",
>> + "pll_abpll",
>> +};
>> +
>> +static int rk3399_register_dmcclk(struct rk3399_dmcclk *dmc)
>> +{
>> + struct clk_init_data init;
>> + struct clk *clk;
>> +
>> + init.name = "dmc_clk";
>> + init.parent_names = parent_clk_names;
>> + init.num_parents = ARRAY_SIZE(parent_clk_names);
>> + init.ops = &rk3399_dmcclk_ops;
>> + init.flags = 0;
>> + dmc->hw->init = &init;
>> +
>> + clk = devm_clk_register(dmc->dev, dmc->hw);
>> + if (IS_ERR(clk)) {
>> + dev_err(dmc->dev, "could not register cpuclk dmc_clk\n");
>> + return PTR_ERR(clk);
>> + }
>> + clk_register_clkdev(clk, "dmc_clk", NULL);
>> + of_clk_add_provider(dmc->dev->of_node, of_clk_src_simple_get, clk);
>> +
>> + return 0;
>> +}
>> +
>> +static int rk3399_dmcclk_probe(struct platform_device *pdev)
>> +{
>> + struct rk3399_dmcclk *dmc;
>> + struct resource *res;
>> + struct device_node *node;
>> + int ret;
>> +
>> + dmc = devm_kzalloc(&pdev->dev, sizeof(*dmc), GFP_KERNEL);
>> + if (!dmc)
>> + return -ENOMEM;
>> +
>> + dmc->hw = devm_kzalloc(&pdev->dev, sizeof(*dmc->hw), GFP_KERNEL);
>> + if (!dmc->hw)
>> + return -ENOMEM;
>> +
>> + dmc->dev = &pdev->dev;
>> +
>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> + dmc->ctrl_regs = devm_ioremap_resource(&pdev->dev, res);
>> + if (IS_ERR(dmc->ctrl_regs))
>> + return PTR_ERR(dmc->ctrl_regs);
>> +
>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
>> + dmc->dfi_regs = devm_ioremap_resource(&pdev->dev, res);
>> + if (IS_ERR(dmc->dfi_regs))
>> + return PTR_ERR(dmc->dfi_regs);
>> +
>> + node = of_parse_phandle(dmc->dev->of_node, "rockchip,cru", 0);
>> + if (!node)
>> + return -ENODEV;
>> +
>> + ret = of_address_to_resource(node, 0, res);
>> + if (ret)
>> + return ret;
>> +
>> + dmc->cru = devm_ioremap_resource(&pdev->dev, res);
>> + if (IS_ERR(dmc->cru))
>> + return PTR_ERR(dmc->cru);
>> +
>> + /* register dpllddr clock */
>> + ret = rk3399_register_dmcclk(dmc);
>> + if (ret) {
>> + dev_err(dmc->dev, "failed to register clk dmc_clk %d\n", ret);
>> + return ret;
>> + }
>> +
>> + platform_set_drvdata(pdev, dmc);
>> + platform_device_register_data(dmc->dev, "rk3399-dmc-freq",
>> + PLATFORM_DEVID_AUTO, NULL, 0);
>> +
>> + return 0;
>> +}
>> +
>> +static const struct of_device_id rk3399_dmcclk_of_match[] = {
>> + { .compatible = "rockchip,rk3399-dmc", },
>> + { },
>> +};
>> +MODULE_DEVICE_TABLE(of, rk3399_dmcclk_of_match);
>> +
>> +
>> +static struct platform_driver rk3399_dmcclk_driver = {
>> + .probe = rk3399_dmcclk_probe,
>> + .driver = {
>> + .name = "rk3399-dmc",
>> + .of_match_table = rk3399_dmcclk_of_match,
>> + .suppress_bind_attrs = true,
>> + },
>> +};
>> +
>> +static int __init rk3399_dmcclk_modinit(void)
>> +{
>> + int ret;
>> +
>> + ret = platform_driver_register(&rk3399_dmcclk_driver);
>> + if (ret < 0)
>> + pr_err("Failed to register platform driver %s\n",
>> + rk3399_dmcclk_driver.driver.name);
>> +
>> + return ret;
>> +}
>> +
>> +module_init(rk3399_dmcclk_modinit);
>> +
>> +MODULE_DESCRIPTION("rockchip rk3399 DMC CLK driver");
>> +MODULE_LICENSE("GPL v2");
>> +
>> diff --git a/include/soc/rockchip/rk3399-dmc-clk.h b/include/soc/rockchip/rk3399-dmc-clk.h
>> new file mode 100644
>> index 0000000..b53fc23
>> --- /dev/null
>> +++ b/include/soc/rockchip/rk3399-dmc-clk.h
>> @@ -0,0 +1,36 @@
>> +/*
>> +* Copyright (C) Fuzhou Rockchip Electronics Co.Ltd
>> +*
>> +* This program is free software; you can redistribute it and/or modify it
>> +* under the terms of the GNU General Public License as published by the
>> +* Free Software Foundation; either version 2 of the License, or (at your
>> +* option) any later version.
>> +*/
>> +
>> +#ifndef _RK3399_DMC_CLK_H
>> +#define _RK3399_DMC_CLK_H
>> +
>> +enum dram_type_tag {
>> + DDR3 = 6,
>> + LPDDR3 = 7,
>> + LPDDR4 = 0x0b,
>> +};
>> +
>> +/* DENALI_CTL_00 */
>> +#define DENALI_CTL_00 0x00
>> +#define DRAM_CLASS_MASK 0x0f
>> +#define DRAM_CLASS_SHIFT 0x8
>> +
>> +struct rk3399_dmcclk {
>> + struct device *dev;
>> + struct clk_hw *hw;
>> + u32 cur_freq;
>> + u32 target_freq;
>> + u32 ddr_type;
>> + void __iomem *ctrl_regs;
>> + void __iomem *dfi_regs;
>> + void __iomem *cru;
>> +};
>> +
>> +#endif
>> +
>>
>
>
>
--
Lin Huang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists