linux-kernel - Re: [PATCH] mtip32xx: use formatting capability of kthread_create_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x49ziy8d6yw.fsf@segfault.boston.devel.redhat.com>
Date:	Fri, 20 Nov 2015 10:29:59 -0500
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:	Jens Axboe <axboe@...com>,
	Asai Thambi SP <asamymuthupa@...ron.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtip32xx: use formatting capability of kthread_create_on_node

Rasmus Villemoes <linux@...musvillemoes.dk> writes:

> kthread_create_on_node takes format+args, so there's no need to do the
> pretty-printing in advance. Moreover, "mtip_svc_thd_99" (including its
> '\0') only just fits in 16 bytes, so if index could ever go above 99
> we'd have a stack buffer overflow.

I don't know of any systems with enough pci slots to expand index
beyond 99.  However, the patch looks like a good cleanup to me.

Reviewed-by: Jeff Moyer <jmoyer@...hat.com>

> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> ---
>  drivers/block/mtip32xx/mtip32xx.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
> index a28a562f7b7f..3457ac8c03e2 100644
> --- a/drivers/block/mtip32xx/mtip32xx.c
> +++ b/drivers/block/mtip32xx/mtip32xx.c
> @@ -3810,7 +3810,6 @@ static int mtip_block_initialize(struct driver_data *dd)
>  	sector_t capacity;
>  	unsigned int index = 0;
>  	struct kobject *kobj;
> -	unsigned char thd_name[16];
>  
>  	if (dd->disk)
>  		goto skip_create_disk; /* hw init done, before rebuild */
> @@ -3958,10 +3957,9 @@ skip_create_disk:
>  	}
>  
>  start_service_thread:
> -	sprintf(thd_name, "mtip_svc_thd_%02d", index);
>  	dd->mtip_svc_handler = kthread_create_on_node(mtip_service_thread,
> -						dd, dd->numa_node, "%s",
> -						thd_name);
> +						dd, dd->numa_node,
> +						"mtip_svc_thd_%02d", index);
>  
>  	if (IS_ERR(dd->mtip_svc_handler)) {
>  		dev_err(&dd->pdev->dev, "service thread failed to start\n");
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/