linux-kernel - Re: [PATCH] mtip32xx: use formatting capability of kthread_create_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <564F680B.2060301@fb.com>
Date:	Fri, 20 Nov 2015 11:35:55 -0700
From:	Jens Axboe <axboe@...com>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Asai Thambi SP <asamymuthupa@...ron.com>,
	Jeff Moyer <jmoyer@...hat.com>
CC:	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtip32xx: use formatting capability of
 kthread_create_on_node

On 11/20/2015 02:46 AM, Rasmus Villemoes wrote:
> kthread_create_on_node takes format+args, so there's no need to do the
> pretty-printing in advance. Moreover, "mtip_svc_thd_99" (including its
> '\0') only just fits in 16 bytes, so if index could ever go above 99
> we'd have a stack buffer overflow.

Applied, thanks.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/